[BugFix] Fix and simplify completion API usage streaming #9475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to what was done for the chat API in vllm-project#9357. Ensure that the final chunk with usage data contains aggregate counts across all choices. Also simplify some of the prompt-handling logic in the API implementation.
|
Draft because there are typing errors that will be fixed by #9473. Edit: strange that the CI didn't fail with the same mypy errors that I see locally... |
DarkLight1337
approved these changes
Oct 18, 2024
charlifu
pushed a commit
to charlifu/vllm
that referenced
this pull request
Oct 23, 2024
…t#9475) Signed-off-by: charlifu <[email protected]>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Oct 23, 2024
…t#9475) Signed-off-by: Vinay Damodaran <[email protected]>
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…t#9475) Signed-off-by: Alvant <[email protected]>
garg-amit
pushed a commit
to garg-amit/vllm
that referenced
this pull request
Oct 28, 2024
…t#9475) Signed-off-by: Amit Garg <[email protected]>
FerdinandZhong
pushed a commit
to FerdinandZhong/vllm
that referenced
this pull request
Oct 29, 2024
…t#9475) Signed-off-by: qishuai <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
…t#9475) Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 20, 2024
…t#9475) Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
…t#9475) Signed-off-by: Tyler Michael Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what was done for the chat API in #9357. Ensure that the final chunk with usage data contains aggregate counts across all choices.
Also simplify some of the prompt-handling logic in the API implementation.