Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Rename input data types #8688

Merged
merged 27 commits into from
Oct 16, 2024
Merged

[Core] Rename input data types #8688

merged 27 commits into from
Oct 16, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Sep 21, 2024 •
edited
Loading

More changes split out from #6869:

  • LLMInputs to TokenInputs (preprocessing), SingletonInputs (sequence) or DecoderOnlyInputs (VLM processors)
    • LLMInputs import will remain available for one release before being removed entirely.
  • EncoderDecoderLLMInputs to EncoderDecoderInputs
    • EncoderDecoderLLMInputs import will remain available for one release before being removed entirely.
  • is_valid_encoder_decoder_llm_inputs to is_encoder_decoder_inputs
    • No backward compatibility for this method as it's not expected to be used outside of internal preprocessing code.

Follow-up to #8687:

  • Rename from_token_counts to from_prompt_token_counts
  • Add docstrings in the constructors of SequenceData

@DarkLight1337
Rename input data types:
c618001 
- `LLMInputs` to `TokenInputs` (preprocessing), `SingletonInputs` (sequence) or `DecoderOnlyInputs` (VLM processors)
- `EncoderDecoderLLMInputs` to `EncoderDecoderInputs`
- `is_valid_encoder_decoder_llm_inputs` to `is_encoder_decoder_inputs`
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 21, 2024
@DarkLight1337 DarkLight1337 changed the title [Core] Rename input data types: [Core] Rename input data types Sep 21, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 force-pushed the rename-inputs branch 2 times, most recently from d030da9 to 0f911ce Compare September 23, 2024 02:14
@DarkLight1337 DarkLight1337 mentioned this pull request Sep 24, 2024
Merged
@DarkLight1337 DarkLight1337 marked this pull request as draft September 25, 2024 06:18
@DarkLight1337 DarkLight1337 marked this pull request as ready for review September 25, 2024 16:47
@DarkLight1337 DarkLight1337 marked this pull request as draft September 27, 2024 02:10
@DarkLight1337 DarkLight1337 marked this pull request as ready for review September 27, 2024 04:10
@DarkLight1337
Copy link
Member Author

@ywang96 this PR is ready for review.

@DarkLight1337 DarkLight1337 removed the ready ONLY add when PR is ready to merge/full CI is needed label Sep 27, 2024
@DarkLight1337 DarkLight1337 mentioned this pull request Oct 5, 2024
Open
@Isotr0py
Copy link
Collaborator

Seems that there are conflicts in mllama. And we need to modify the newly added glm-4v and molmo as well (these two models haven't covered by correctness test on CI yet).

@DarkLight1337
Copy link
Member Author

Let me update them real quick.

@Isotr0py Isotr0py enabled auto-merge (squash) October 16, 2024 07:08
@Isotr0py Isotr0py merged commit cee711f into main Oct 16, 2024
58 checks passed
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
@DarkLight1337 @charlifu
[Core] Rename input data types (vllm-project#8688)
c4ce398 
Signed-off-by: charlifu <[email protected]>
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Oct 23, 2024
@DarkLight1337 @vrdn-23
[Core] Rename input data types (vllm-project#8688)
c996b09 
Signed-off-by: Vinay Damodaran <[email protected]>
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@DarkLight1337 @Alvant
[Core] Rename input data types (vllm-project#8688)
f384d7b 
Signed-off-by: Alvant <[email protected]>
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
@DarkLight1337 @garg-amit
[Core] Rename input data types (vllm-project#8688)
739e922 
Signed-off-by: Amit Garg <[email protected]>
@simon-mo simon-mo deleted the rename-inputs branch October 28, 2024 16:51
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@DarkLight1337 @FerdinandZhong
[Core] Rename input data types (vllm-project#8688)
5e4c503 
Signed-off-by: qishuai <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@DarkLight1337 @sumitd2
[Core] Rename input data types (vllm-project#8688)
93a9877 
Signed-off-by: Sumit Dubey <[email protected]>
tjohnson31415 added a commit to opendatahub-io/vllm-tgis-adapter that referenced this pull request Nov 15, 2024
@tjohnson31415
remove use of deprecated LLMInputs
96beaf6 
REF vllm-project/vllm#8688

Signed-off-by: Travis Johnson <[email protected]>
@tjohnson31415 tjohnson31415 mentioned this pull request Nov 15, 2024
Merged
3 tasks
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@DarkLight1337
[Core] Rename input data types (vllm-project#8688)
703d9a0
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@DarkLight1337 @mfournioux
[Core] Rename input data types (vllm-project#8688)
c07af98 
Signed-off-by: Maxime Fournioux <[email protected]>
github-merge-queue bot pushed a commit to opendatahub-io/vllm-tgis-adapter that referenced this pull request Dec 2, 2024
@tjohnson31415 @dtrifiro
remove use of deprecated LLMInputs
f0ac393 
REF vllm-project/vllm#8688

Signed-off-by: Travis Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123 zhuohan123 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkLight1337 @Isotr0py