Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] add punica dimensions for granite 20b #6962

Closed

Conversation

prashantgupta24
Copy link
Contributor

@prashantgupta24 prashantgupta24 commented Jul 30, 2024

This PR adds dimensions to the punica kernel to work with the 20b family of IBM granite models.

Similar to what was done here: #5559

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@prashantgupta24 prashantgupta24 changed the title 🐛 add punica dimensions for granite 20b [Kernel] add punica dimensions for granite 20b Jul 30, 2024
@prashantgupta24 prashantgupta24 marked this pull request as ready for review July 30, 2024 22:32
@prashantgupta24
Copy link
Contributor Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 31, 2024
@Yard1
Copy link
Collaborator

Yard1 commented Aug 1, 2024

Should not be necessary with #5036 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants