Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Remove VLLM_BUILD_WITH_NEURON env variable #5389

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

WoosukKwon
Copy link
Collaborator

Use VLLM_TARGET_DEVICE instead of VLLM_BUILD_WITH_NEURON.

Copy link
Contributor

@liangfu liangfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WoosukKwon WoosukKwon enabled auto-merge (squash) June 10, 2024 18:23
@WoosukKwon WoosukKwon disabled auto-merge June 11, 2024 07:37
@WoosukKwon WoosukKwon merged commit 8bab495 into main Jun 11, 2024
101 of 103 checks passed
@WoosukKwon WoosukKwon deleted the neuron-env branch June 11, 2024 07:37
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jun 12, 2024
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 27, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants