Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Ray usage stats collection #2206

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Disable Ray usage stats collection #2206

merged 1 commit into from
Dec 21, 2023

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Dec 19, 2023

I just got to know that Ray collects usage data by default. Let's disable it.

@Lvjinhong
Copy link

I just got to know that Ray collects usage data by default. Let's disable it.

So, will this have any impact on performance, or is it just a personal preference? I am passionate about high-performance inference, so I'm considering replacing Ray with TorchRun to potentially boost the performance of vLLM.

@zhuohan123
Copy link
Member

I just got to know that Ray collects usage data by default. Let's disable it.

So, will this have any impact on performance, or is it just a personal preference? I am passionate about high-performance inference, so I'm considering replacing Ray with TorchRun to potentially boost the performance of vLLM.

This is not related to performance. The changes in #2221 are more related to performance. Will include more details there.

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WoosukKwon WoosukKwon merged commit 3a4fd5c into main Dec 21, 2023
2 checks passed
@WoosukKwon WoosukKwon deleted the disable-ray-usage branch December 21, 2023 05:52
@richardliaw
Copy link
Collaborator

No action needed, but just adding a bit of clarification -- this PR will not do anything because the usage stats collection was already disabled before this PR.

I believe vLLM does not force the user to run ray start or ray up in the CLI, which is the only way where usage stats collection is enabled (documentation here).

Let me know if I missed anything!

usage stats collection is not enabled when using local dev clusters started via ray.init() unless it’s a nightly wheel. This means that Ray will never collect data from third-party library users not using Ray directly.

@WoosukKwon
Copy link
Collaborator Author

WoosukKwon commented Dec 21, 2023

@richardliaw Thanks for the clarification! I recently used Ray nightly for the first time and misunderstood that this was enabled by default.

hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants