Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Remove performance warning for auto_awq.md #12743

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Feb 4, 2025

No description provided.

Copy link

github-actions bot commented Feb 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 4, 2025
@mgoin mgoin requested a review from hmellor February 4, 2025 17:45
Copy link
Collaborator

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I always wondered when this warning would go away 🤔

@DarkLight1337 DarkLight1337 changed the title Remove performance warning for auto_awq.md [Doc] Remove performance warning for auto_awq.md Feb 5, 2025
@simon-mo simon-mo merged commit c53dc46 into main Feb 5, 2025
21 of 23 checks passed
@simon-mo simon-mo deleted the awq-perf-warning-removal branch February 5, 2025 06:43
@korgmp3
Copy link

korgmp3 commented Feb 5, 2025

Hi.
Has under-optimized AWQ issue been solved?

@mgoin
Copy link
Member Author

mgoin commented Feb 6, 2025

fxmarty-amd pushed a commit to fxmarty-amd/vllm that referenced this pull request Feb 7, 2025
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants