-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] [Bugfix] Fix loading of fine-tuned models based on Phi-3-Small #12689
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Michael Greenbaum <[email protected]>
ab8ca5d
to
0fcd244
Compare
Signed-off-by: Michael Greenbaum <[email protected]>
Signed-off-by: Michael Greenbaum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
…project#12689) Signed-off-by: Michael Greenbaum <[email protected]> Co-authored-by: Michael Greenbaum <[email protected]> Signed-off-by: Felix Marty <[email protected]>
…project#12689) Signed-off-by: Michael Greenbaum <[email protected]> Co-authored-by: Michael Greenbaum <[email protected]>
…project#12689) Signed-off-by: Michael Greenbaum <[email protected]> Co-authored-by: Michael Greenbaum <[email protected]>
We have a fine-tuned model based on Phi-3-Small and loading it fails due to this issue.
It's an official model, created by a team in Microsoft, that handles financial reports.
Model information exists here: https://ai.azure.com/explore/models/financial-reports-analysis/version/2/registry/azureml
The error we get:
This fix was verified by successfully loading the model.
We also saw the exact same fix for other models:
commandr.py
,gemma.py
,gpt_bigcode.py
andjais.py
.