Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Add SPDX-License-Identifier headers to python source files #12628

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

russellb
Copy link
Member

  • Add SPDX license headers to python source files
  • Check for SPDX headers using pre-commit

commit 9d7ef44
Author: Russell Bryant [email protected]
Date: Fri Jan 31 14:18:24 2025 -0500

Add SPDX license headers to python source files

This commit adds SPDX license headers to python source files as recommended to
the project by the Linux Foundation. These headers provide a concise way that is
both human and machine readable for communicating license information for each
source file. It helps avoid any ambiguity about the license of the code and can
also be easily used by tools to help manage license compliance.

The Linux Foundation runs license scans against the codebase to help ensure
we are in compliance with the licenses of the code we use, including
dependencies. Having these headers in place helps that tool do its job.

More information can be found on the SPDX site:

- https://spdx.dev/learn/handling-license-info/

Signed-off-by: Russell Bryant <[email protected]>

commit 5a1cf1c
Author: Russell Bryant [email protected]
Date: Fri Jan 31 14:36:32 2025 -0500

Check for SPDX headers using pre-commit

Signed-off-by: Russell Bryant <[email protected]>

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation ci/build frontend labels Jan 31, 2025
Copy link

mergify bot commented Jan 31, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @russellb.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@DarkLight1337
Copy link
Member

Let's do this on the weekend and avoid merging other commits to avoid conflicts while running the CI. cc @simon-mo

@russellb
Copy link
Member Author

russellb commented Feb 1, 2025

Let's do this on the weekend and avoid merging other commits to avoid conflicts while running the CI. cc @simon-mo

As long as pre-commit passes, I don't think it's worth running the rest of CI on this one. It doesn't touch any real code.

This commit adds SPDX license headers to python source files as recommended to
the project by the Linux Foundation. These headers provide a concise way that is
both human and machine readable for communicating license information for each
source file. It helps avoid any ambiguity about the license of the code and can
also be easily used by tools to help manage license compliance.

The Linux Foundation runs license scans against the codebase to help ensure
we are in compliance with the licenses of the code we use, including
dependencies. Having these headers in place helps that tool do its job.

More information can be found on the SPDX site:

- https://spdx.dev/learn/handling-license-info/

Signed-off-by: Russell Bryant <[email protected]>
@simon-mo simon-mo merged commit e489ad7 into vllm-project:main Feb 2, 2025
6 of 9 checks passed
youngkent pushed a commit to youngkent/vllm that referenced this pull request Feb 3, 2025
…lm-project#12628)

- **Add SPDX license headers to python source files**
- **Check for SPDX headers using pre-commit**

commit 9d7ef44
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:18:24 2025 -0500

    Add SPDX license headers to python source files
    
This commit adds SPDX license headers to python source files as
recommended to
the project by the Linux Foundation. These headers provide a concise way
that is
both human and machine readable for communicating license information
for each
source file. It helps avoid any ambiguity about the license of the code
and can
    also be easily used by tools to help manage license compliance.
    
The Linux Foundation runs license scans against the codebase to help
ensure
    we are in compliance with the licenses of the code we use, including
dependencies. Having these headers in place helps that tool do its job.
    
    More information can be found on the SPDX site:
    
    - https://spdx.dev/learn/handling-license-info/
    
    Signed-off-by: Russell Bryant <[email protected]>

commit 5a1cf1c
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:36:32 2025 -0500

    Check for SPDX headers using pre-commit
    
    Signed-off-by: Russell Bryant <[email protected]>

---------

Signed-off-by: Russell Bryant <[email protected]>
srikanthsrnvs pushed a commit to srikanthsrnvs/vllm that referenced this pull request Feb 3, 2025
…lm-project#12628)

- **Add SPDX license headers to python source files**
- **Check for SPDX headers using pre-commit**

commit 9d7ef44
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:18:24 2025 -0500

    Add SPDX license headers to python source files

This commit adds SPDX license headers to python source files as
recommended to
the project by the Linux Foundation. These headers provide a concise way
that is
both human and machine readable for communicating license information
for each
source file. It helps avoid any ambiguity about the license of the code
and can
    also be easily used by tools to help manage license compliance.

The Linux Foundation runs license scans against the codebase to help
ensure
    we are in compliance with the licenses of the code we use, including
dependencies. Having these headers in place helps that tool do its job.

    More information can be found on the SPDX site:

    - https://spdx.dev/learn/handling-license-info/

    Signed-off-by: Russell Bryant <[email protected]>

commit 5a1cf1c
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:36:32 2025 -0500

    Check for SPDX headers using pre-commit

    Signed-off-by: Russell Bryant <[email protected]>

---------

Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Srikanth Srinivas <[email protected]>
@khluu khluu mentioned this pull request Feb 3, 2025
sahelib25 pushed a commit to krai/vllm that referenced this pull request Feb 3, 2025
…lm-project#12628)

- **Add SPDX license headers to python source files**
- **Check for SPDX headers using pre-commit**

commit 9d7ef44
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:18:24 2025 -0500

    Add SPDX license headers to python source files
    
This commit adds SPDX license headers to python source files as
recommended to
the project by the Linux Foundation. These headers provide a concise way
that is
both human and machine readable for communicating license information
for each
source file. It helps avoid any ambiguity about the license of the code
and can
    also be easily used by tools to help manage license compliance.
    
The Linux Foundation runs license scans against the codebase to help
ensure
    we are in compliance with the licenses of the code we use, including
dependencies. Having these headers in place helps that tool do its job.
    
    More information can be found on the SPDX site:
    
    - https://spdx.dev/learn/handling-license-info/
    
    Signed-off-by: Russell Bryant <[email protected]>

commit 5a1cf1c
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:36:32 2025 -0500

    Check for SPDX headers using pre-commit
    
    Signed-off-by: Russell Bryant <[email protected]>

---------

Signed-off-by: Russell Bryant <[email protected]>
fxmarty-amd pushed a commit to fxmarty-amd/vllm that referenced this pull request Feb 7, 2025
…lm-project#12628)

- **Add SPDX license headers to python source files**
- **Check for SPDX headers using pre-commit**

commit 9d7ef44
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:18:24 2025 -0500

    Add SPDX license headers to python source files

This commit adds SPDX license headers to python source files as
recommended to
the project by the Linux Foundation. These headers provide a concise way
that is
both human and machine readable for communicating license information
for each
source file. It helps avoid any ambiguity about the license of the code
and can
    also be easily used by tools to help manage license compliance.

The Linux Foundation runs license scans against the codebase to help
ensure
    we are in compliance with the licenses of the code we use, including
dependencies. Having these headers in place helps that tool do its job.

    More information can be found on the SPDX site:

    - https://spdx.dev/learn/handling-license-info/

    Signed-off-by: Russell Bryant <[email protected]>

commit 5a1cf1c
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:36:32 2025 -0500

    Check for SPDX headers using pre-commit

    Signed-off-by: Russell Bryant <[email protected]>

---------

Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Felix Marty <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Feb 7, 2025
…lm-project#12628)

- **Add SPDX license headers to python source files**
- **Check for SPDX headers using pre-commit**

commit 9d7ef44
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:18:24 2025 -0500

    Add SPDX license headers to python source files

This commit adds SPDX license headers to python source files as
recommended to
the project by the Linux Foundation. These headers provide a concise way
that is
both human and machine readable for communicating license information
for each
source file. It helps avoid any ambiguity about the license of the code
and can
    also be easily used by tools to help manage license compliance.

The Linux Foundation runs license scans against the codebase to help
ensure
    we are in compliance with the licenses of the code we use, including
dependencies. Having these headers in place helps that tool do its job.

    More information can be found on the SPDX site:

    - https://spdx.dev/learn/handling-license-info/

    Signed-off-by: Russell Bryant <[email protected]>

commit 5a1cf1c
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:36:32 2025 -0500

    Check for SPDX headers using pre-commit

    Signed-off-by: Russell Bryant <[email protected]>

---------

Signed-off-by: Russell Bryant <[email protected]>
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
…lm-project#12628)

- **Add SPDX license headers to python source files**
- **Check for SPDX headers using pre-commit**

commit 9d7ef44
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:18:24 2025 -0500

    Add SPDX license headers to python source files
    
This commit adds SPDX license headers to python source files as
recommended to
the project by the Linux Foundation. These headers provide a concise way
that is
both human and machine readable for communicating license information
for each
source file. It helps avoid any ambiguity about the license of the code
and can
    also be easily used by tools to help manage license compliance.
    
The Linux Foundation runs license scans against the codebase to help
ensure
    we are in compliance with the licenses of the code we use, including
dependencies. Having these headers in place helps that tool do its job.
    
    More information can be found on the SPDX site:
    
    - https://spdx.dev/learn/handling-license-info/
    
    Signed-off-by: Russell Bryant <[email protected]>

commit 5a1cf1c
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:36:32 2025 -0500

    Check for SPDX headers using pre-commit
    
    Signed-off-by: Russell Bryant <[email protected]>

---------

Signed-off-by: Russell Bryant <[email protected]>
GWS0428 pushed a commit to GWS0428/VARserve that referenced this pull request Feb 12, 2025
…lm-project#12628)

- **Add SPDX license headers to python source files**
- **Check for SPDX headers using pre-commit**

commit 9d7ef44
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:18:24 2025 -0500

    Add SPDX license headers to python source files
    
This commit adds SPDX license headers to python source files as
recommended to
the project by the Linux Foundation. These headers provide a concise way
that is
both human and machine readable for communicating license information
for each
source file. It helps avoid any ambiguity about the license of the code
and can
    also be easily used by tools to help manage license compliance.
    
The Linux Foundation runs license scans against the codebase to help
ensure
    we are in compliance with the licenses of the code we use, including
dependencies. Having these headers in place helps that tool do its job.
    
    More information can be found on the SPDX site:
    
    - https://spdx.dev/learn/handling-license-info/
    
    Signed-off-by: Russell Bryant <[email protected]>

commit 5a1cf1c
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:36:32 2025 -0500

    Check for SPDX headers using pre-commit
    
    Signed-off-by: Russell Bryant <[email protected]>

---------

Signed-off-by: Russell Bryant <[email protected]>
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
…lm-project#12628)

- **Add SPDX license headers to python source files**
- **Check for SPDX headers using pre-commit**

commit 9d7ef44
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:18:24 2025 -0500

    Add SPDX license headers to python source files
    
This commit adds SPDX license headers to python source files as
recommended to
the project by the Linux Foundation. These headers provide a concise way
that is
both human and machine readable for communicating license information
for each
source file. It helps avoid any ambiguity about the license of the code
and can
    also be easily used by tools to help manage license compliance.
    
The Linux Foundation runs license scans against the codebase to help
ensure
    we are in compliance with the licenses of the code we use, including
dependencies. Having these headers in place helps that tool do its job.
    
    More information can be found on the SPDX site:
    
    - https://spdx.dev/learn/handling-license-info/
    
    Signed-off-by: Russell Bryant <[email protected]>

commit 5a1cf1c
Author: Russell Bryant <[email protected]>
Date:   Fri Jan 31 14:36:32 2025 -0500

    Check for SPDX headers using pre-commit
    
    Signed-off-by: Russell Bryant <[email protected]>

---------

Signed-off-by: Russell Bryant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants