Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Gracefully handle huggingface hub http error #12571

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Jan 30, 2025

Currently if huggingface hub is down, users cannot start the engine because of the following code that always checks against the hub if the specified model has a encoder config, even though the users have all the other files available locally.

self.encoder_config = self._get_encoder_config()

vllm/vllm/config.py

Lines 417 to 419 in f17f1d4

def _get_encoder_config(self):
return get_sentence_transformer_tokenizer_config(
self.model, self.revision)

This PR gracefully handles the http error from huggingface hub and gives warnings if there's indeed connection issue.

IMO a proper fix for this issue should be optionally calling _get_encoder_config to check against the hub (though I'm not sure there's a good way to do so) cc @flaviabeo @maxdebayser

Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@ywang96
Copy link
Member Author

ywang96 commented Jan 30, 2025

Thanks @charlesfrye for finding out the root cause!

@simon-mo
Copy link
Collaborator

non blocking, can we figure out a way to test this? maybe edit /etc/hosts to block huggingface.co to see whether offline mode is truly working

Copy link
Contributor

@maxdebayser maxdebayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Signed-off-by: Roger Wang <[email protected]>
vllm/transformers_utils/config.py Outdated Show resolved Hide resolved
@comaniac comaniac enabled auto-merge (squash) January 30, 2025 16:25
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 30, 2025
Signed-off-by: Roger Wang <[email protected]>
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🙏 🙏

@comaniac comaniac merged commit 7a8987d into main Jan 31, 2025
46 checks passed
@comaniac comaniac deleted the fix-file-download branch January 31, 2025 08:19
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
youngkent pushed a commit to youngkent/vllm that referenced this pull request Feb 3, 2025
srikanthsrnvs pushed a commit to srikanthsrnvs/vllm that referenced this pull request Feb 3, 2025
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Feb 7, 2025
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
GWS0428 pushed a commit to GWS0428/VARserve that referenced this pull request Feb 12, 2025
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants