-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Gracefully handle huggingface hub http error #12571
Conversation
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Thanks @charlesfrye for finding out the root cause! |
non blocking, can we figure out a way to test this? maybe edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 🙏 🙏
…2571) Signed-off-by: Isotr0py <[email protected]>
…2571) Signed-off-by: Srikanth Srinivas <[email protected]>
Currently if huggingface hub is down, users cannot start the engine because of the following code that always checks against the hub if the specified model has a encoder config, even though the users have all the other files available locally.
vllm/vllm/config.py
Line 299 in f17f1d4
vllm/vllm/config.py
Lines 417 to 419 in f17f1d4
This PR gracefully handles the http error from huggingface hub and gives warnings if there's indeed connection issue.
IMO a proper fix for this issue should be optionally calling
_get_encoder_config
to check against the hub (though I'm not sure there's a good way to do so) cc @flaviabeo @maxdebayser