[V1][BugFix] Free encoder cache for aborted requests #12545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Woosuk Kwon <[email protected]>
WoosukKwon
requested review from
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
robertgshaw2-redhat
approved these changes
Jan 29, 2025
comaniac
approved these changes
Jan 29, 2025
ywang96
approved these changes
Jan 29, 2025
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
github-actions
bot
added
the
ready
Signed-off-by: Woosuk Kwon <[email protected]>
rasmith
pushed a commit
to rasmith/vllm
that referenced
this pull request
Jan 30, 2025
) Signed-off-by: Woosuk Kwon <[email protected]>
Isotr0py
pushed a commit
to Isotr0py/vllm
that referenced
this pull request
Feb 2, 2025
) Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Isotr0py <[email protected]>
youngkent
pushed a commit
to youngkent/vllm
that referenced
this pull request
Feb 3, 2025
) Signed-off-by: Woosuk Kwon <[email protected]>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Feb 7, 2025
) Signed-off-by: Woosuk Kwon <[email protected]>
ShangmingCai
pushed a commit
to ShangmingCai/vllm
that referenced
this pull request
Feb 10, 2025
) Signed-off-by: Woosuk Kwon <[email protected]>
GWS0428
pushed a commit
to GWS0428/VARserve
that referenced
this pull request
Feb 12, 2025
) Signed-off-by: Woosuk Kwon <[email protected]>
panf2333
pushed a commit
to yottalabsai/vllm
that referenced
this pull request
Feb 18, 2025
) Signed-off-by: Woosuk Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that encoder cache is not properly freed when the request is aborted.
Plus, this PR includes minor code cleanup.