Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VLM] Merged multi-modal processor for Pixtral #12211

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[VLM] Merged multi-modal processor for Pixtral #12211

wants to merge 8 commits into from

Conversation

Flechman
Copy link

This PR aims at implementing the merged multi-modal processor for Pixtral as an effort to contribute to the V1 re-arch for multi-modal models.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

This was referenced Jan 20, 2025
Open
Open
mgoin
mgoin reviewed Jan 20, 2025
View reviewed changes
vllm/model_executor/models/pixtral.py Outdated
Comment on lines 202 to 207
@MULTIMODAL_REGISTRY.register_processor(PixtralHFMultiModalProcessor,
info=PixtralHFProcessingInfo,
dummy_inputs=PixtralHFDummyInputBuilder
)
class PixtralForConditionalGeneration(nn.Module, SupportsMultiModal,
SupportsPP):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the same processor for the mistral-format and the hf-format now?

@Flechman Flechman force-pushed the pixtral-mm-processor branch from 41c423a to 4af1716 Compare January 26, 2025 12:19
@DarkLight1337
Copy link
Member

#12767 should make it easier to pass the image token ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin left review comments

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 will be requested when the pull request is marked ready for review DarkLight1337 is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 will be requested when the pull request is marked ready for review ywang96 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@DarkLight1337 DarkLight1337

@ywang96 ywang96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Flechman @DarkLight1337 @mgoin @ywang96