Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] improve memory profiling #11809
[misc] improve memory profiling #11809
Changes from 6 commits
ae6e5ae
9a3c964
fccb65f
c83b3b9
9fc3db7
f07c38c
5f61195
c86efad
f6a6222
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool!
I'm a bit confused on how it's useful though, since we're testing a test utility that isn't used in the actual memory profiling? Did we want to enable
monitor(measure_current_non_torch)
during the actual profile run to try to get an accurate measure of the peak non-torch memory usage?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the current memory profiling, we mainly use
torch.cuda.memory_reserved()
to replacetorch.cuda.memory_stats()["allocated_bytes.all.current"]
.the utility function is more about future-proof, we can get the ground-truth non-torch memory, which will help us profile which part of memory can be offloaded in RLHF workload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohhh nice, I didn't catch that there was a peak measurement for the total reserved memory as well