-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] IBM Granite 3.1 #11307
[Model] IBM Granite 3.1 #11307
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see no modeling changes. LGTM after removing print and with green build
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
16c09d5
to
52c8e69
Compare
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]> Signed-off-by: Bowen Wang <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
IBM just released new Granite 3.1 models (Press Release; HF Hub).
Tool calling with the new version is different becuase it uses a
<tool_call>
html-style string to mark the start of a tool call response instead of the<|tool_call|>
token. The default chat template from HF Hub passes the unit tests, so I did not add a new chat template jinja file to the examples directory (but the currenttool_chat_template_granite.jinja
file should not be used with the 3.1 models).