Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform] Add verify_quantization in platform. #10757

Merged

Conversation

wangxiyuan
Copy link
Contributor

@wangxiyuan wangxiyuan commented Nov 29, 2024

Part of #9268

  1. Add verify_quantization function and move supported_quantization to platform to avoid unlimited if else usage.
  2. Add device_name to each platform to distinguish the device name. such as, rocm and cuda

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

vllm/config.py Outdated Show resolved Hide resolved
@wangxiyuan wangxiyuan force-pushed the add_supported_quantization branch 2 times, most recently from 86d3190 to a6526bf Compare November 29, 2024 06:38
vllm/platforms/neuron.py Outdated Show resolved Hide resolved
vllm/platforms/rocm.py Outdated Show resolved Hide resolved
vllm/platforms/tpu.py Outdated Show resolved Hide resolved
@wangxiyuan wangxiyuan force-pushed the add_supported_quantization branch from a6526bf to 1c4a5d3 Compare November 29, 2024 06:45
@wangxiyuan wangxiyuan changed the title [platform] Add supported_quantization in platform. [platform] Add verify_quantization in platform. Nov 29, 2024
@DarkLight1337
Copy link
Member

LGTM

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 29, 2024 10:21
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 29, 2024
@DarkLight1337 DarkLight1337 merged commit 661175b into vllm-project:main Nov 29, 2024
57 checks passed
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
@wangxiyuan wangxiyuan deleted the add_supported_quantization branch December 11, 2024 08:50
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@wangxiyuan wangxiyuan mentioned this pull request Dec 19, 2024
1 task
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants