-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Ignore ray reinit error when current platform is ROCm or XPU #10375
Conversation
Just like the else branch, we should also add `ignore_reinit_error=True` when calling ray.init, so that the reinit error can be ignored if vLLM is called by another program and ray has already been initialized: File "vllm/vllm/entrypoints/llm.py", line 213, in __init__ self.llm = vllm.LLM(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^ File "vllm/vllm/utils.py", line 1024, in inner return fn(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^ self.llm_engine = self.engine_class.from_engine_args( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "vllm/vllm/engine/llm_engine.py", line 580, in from_engine_args executor_class = cls._get_executor_cls(engine_config) File "vllm/vllm/engine/llm_engine.py", line 555, in _get_executor_cls initialize_ray_cluster(engine_config.parallel_config) File "vllm/vllm/executor/ray_utils.py", line 237, in initialize_ray_cluster ray.init("auto") ^^^^^^^^^^^^^^^^^^^^^ RuntimeError: Maybe you called ray.init twice by accident? This error can be suppressed by passing in 'ignore_reinit_error=True' or by calling 'ray.shutdown()' prior to 'ray.init()'. Signed-off-by: Hollow Man <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…vllm-project#10375) Signed-off-by: Hollow Man <[email protected]> Signed-off-by: Linkun Chen <[email protected]>
…vllm-project#10375) Signed-off-by: Hollow Man <[email protected]>
…vllm-project#10375) Signed-off-by: Hollow Man <[email protected]>
…vllm-project#10375) Signed-off-by: Hollow Man <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
…vllm-project#10375) Signed-off-by: Hollow Man <[email protected]> Signed-off-by: rickyx <[email protected]>
…vllm-project#10375) Signed-off-by: Hollow Man <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
…vllm-project#10375) Signed-off-by: Hollow Man <[email protected]>
…vllm-project#10375) Signed-off-by: Hollow Man <[email protected]>
Just like the else branch, we should also add
ignore_reinit_error=True
when calling ray.init, so that the reinit error can be ignored if vLLM is called by another program and ray has already been initialized: