Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Ignore ray reinit error when current platform is ROCm or XPU #10375

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

HollowMan6
Copy link
Contributor

@HollowMan6 HollowMan6 commented Nov 15, 2024

Just like the else branch, we should also add ignore_reinit_error=True when calling ray.init, so that the reinit error can be ignored if vLLM is called by another program and ray has already been initialized:

 File "vllm/vllm/entrypoints/llm.py", line 213, in __init__
   self.llm = vllm.LLM(*args, **kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^
 File "vllm/vllm/utils.py", line 1024, in inner
   return fn(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^
   self.llm_engine = self.engine_class.from_engine_args(
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 File "vllm/vllm/engine/llm_engine.py", line 580, in from_engine_args
   executor_class = cls._get_executor_cls(engine_config)
 File "vllm/vllm/engine/llm_engine.py", line 555, in _get_executor_cls
   initialize_ray_cluster(engine_config.parallel_config)
 File "vllm/vllm/executor/ray_utils.py", line 237, in initialize_ray_cluster
   ray.init("auto")
          ^^^^^^^^^^^^^^^^^^^^^
RuntimeError: Maybe you called ray.init twice by accident? This error can be suppressed by passing in 'ignore_reinit_error=True' or by calling 'ray.shutdown()' prior to 'ray.init()'.

Just like the else branch, we should also add `ignore_reinit_error=True`
when calling ray.init, so that the reinit error can be ignored if vLLM
is called by another program and ray has already been initialized:

 File "vllm/vllm/entrypoints/llm.py", line 213, in __init__
   self.llm = vllm.LLM(*args, **kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^
 File "vllm/vllm/utils.py", line 1024, in inner
   return fn(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^
   self.llm_engine = self.engine_class.from_engine_args(
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 File "vllm/vllm/engine/llm_engine.py", line 580, in from_engine_args
   executor_class = cls._get_executor_cls(engine_config)
 File "vllm/vllm/engine/llm_engine.py", line 555, in _get_executor_cls
   initialize_ray_cluster(engine_config.parallel_config)
 File "vllm/vllm/executor/ray_utils.py", line 237, in initialize_ray_cluster
   ray.init("auto")
          ^^^^^^^^^^^^^^^^^^^^^
RuntimeError: Maybe you called ray.init twice by accident?
This error can be suppressed by passing in 'ignore_reinit_error=True'
or by calling 'ray.shutdown()' prior to 'ray.init()'.

Signed-off-by: Hollow Man <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youkaichao youkaichao added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 18, 2024
@DarkLight1337 DarkLight1337 merged commit 47826ca into vllm-project:main Nov 18, 2024
61 of 63 checks passed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 18, 2024
@HollowMan6 HollowMan6 deleted the reinit branch November 18, 2024 08:22
coolkp pushed a commit to coolkp/vllm that referenced this pull request Nov 20, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 20, 2024
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
prashantgupta24 pushed a commit to opendatahub-io/vllm that referenced this pull request Dec 3, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants