Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Fix some help info of arg_utils to improve readability #10362

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

ShangmingCai
Copy link
Contributor

I have noticed some formatting issues in the help info of arg_utils. Specifically, some cases exist where words are connected without spaces when the text wraps to a new line.

For example,

parser.add_argument(
            '--num-gpu-blocks-override',
            type=int,
            default=None,
            help='If specified, ignore GPU profiling result and use this number'
            'of GPU blocks. Used for testing preemption.')
image So I fix all I can find.

cc @DarkLight1337

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the QoL improvement!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 15, 2024 09:52
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 15, 2024
@DarkLight1337 DarkLight1337 merged commit f2056f7 into vllm-project:main Nov 15, 2024
63 checks passed
@ShangmingCai ShangmingCai deleted the fix_arg_utils_typos branch November 18, 2024 03:02
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 20, 2024
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants