Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Ripper. #2749

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MortemobireMortem
Copy link

About The Pull Request

Now split up from the Ensemble PR, it should give him much, much more space to breathe and let him be merged to test the waters.

Why It's Good For The Game

New Urban Nightmare distortion.

Changelog

🆑
add: Adds Time Ripper Distortion
imageadd: 2 placeholder icons that should get their own sprite in future.
/:cl:

Copy link
Collaborator

@Gboster-0 Gboster-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's more thingies, but those are two of em
Also with all the switches all over the place where you are just changing sprites, i'd change the "Ripper" sprite to "Ripper1" and just go icon_state = "Ripper[current_stage]", that or change its living sprite and then change his icon_state to the living sprite whenever you need it

Comment on lines 89 to 91
return


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need a return at the end of code

Suggested change
return

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return has been removed.

Comment on lines +128 to +133
switch(current_stage)
if(1)
icon = 'ModularTegustation/Teguicons/64x64.dmi'
icon_state = "Ripper2"
if(2)
icon_state = "Ripper2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be compressed a lot, unless thats meant to be two unique sprites

Suggested change
switch(current_stage)
if(1)
icon = 'ModularTegustation/Teguicons/64x64.dmi'
icon_state = "Ripper2"
if(2)
icon_state = "Ripper2"
icon_state = "Ripper2"
if(current_stage == 1)
icon = 'ModularTegustation/Teguicons/64x64.dmi'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed they are, without that, his first phase blinks for a split second into invisibility, which looked awkward, so I added that. It was not quite necessary but it gave him more flavor instead of just punching corpse and tearing off its head.

Removes unnecessary return.
@Kitsunemitsu Kitsunemitsu added the Feature Something new being added. label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Something new being added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants