Nobody Is Improvements #2746
Open
Nobody Is Improvements #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coxswain-Navigator
added
Code improvement
InsightfulParasite
added
the
Isolated Code
|
Does this fix #2747 ? |
No, I made the issue because I couldn't figure out how to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR adds the new CopyHumanAppearance() Proc, which creates a dummy mob with the same appearance as a target then copies that dummy. This prevents things like overlays from panic halos or buffs from making the copied appearance look weird. This proc can also be used for other things in the future, but isn't quite perfect currently. Also fixes a bug with the strangle attack from Nobody Is. Nobody Is still has one major bug left to fix, but I'm not sure how to fix it.
Why It's Good For The Game
No more Oberon running around with a giant holographic brain floating over his head, being invisible, and other sprite shenanigans. Hopefully.
Changelog
🆑
fix: fixed Nobody Is sprite stealing issues
/:cl: