Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Station traits Rework/Rebalance #2743

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Kitsunemitsu
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu commented Mar 2, 2025

About The Pull Request

Station Traits now only appear in 50% of all rounds instead of 11%.
-Legacy Pale Trait has been removed.
-Selection Mishap has been removed. While some people like this one, and it's not as hated, it's quite polarizing so
-Abno Blitz weight has been reduced from 5 to 3 weight. It's very polarizing so it's important to keep it low. Some people love it, and some people hate it.
-Joke Abnormalities now Guarantees alternate joke sprites
-Wounds now actually works in the callback trait. This trait is also rather polarizing so it may be removed.
-Working clerks had it's rate reduced from 3 to 2
-Added experimental departmental agents station trait, people have been bitching about it for forever, so testing it as a trait is a good idea. May or may not stick around

Why It's Good For The Game

A small rebalance of Station Traits.
Initial feedback is generally positive, however the system as a whole needs changing to have players like it more.

Removing less liked traits, and making tweaks to other traits.

Changelog

🆑
balance: rebalanced station traits
/:cl:

@Kitsunemitsu Kitsunemitsu added the Balance Improvements towards balance of the game. label Mar 2, 2025
Comment on lines 177 to +181
if(secret_chance && (prob(1)))
InitializeSecretIcon()

if(SSmaptype.chosen_trait == FACILITY_TRAIT_JOKE_ABNOS && secret_chance)
InitializeSecretIcon()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh i think this would be cleaner

Suggested change
if(secret_chance && (prob(1)))
InitializeSecretIcon()
if(SSmaptype.chosen_trait == FACILITY_TRAIT_JOKE_ABNOS && secret_chance)
InitializeSecretIcon()
if(secret_chance && (prob(1) || SSmaptype.chosen_trait == FACILITY_TRAIT_JOKE_ABNOS))
InitializeSecretIcon()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Improvements towards balance of the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants