-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Station traits Rework/Rebalance #2743
Open
Kitsunemitsu
wants to merge
6
commits into
vlggms:master
Choose a base branch
from
Kitsunemitsu:Station-Traits-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gboster-0
reviewed
Mar 3, 2025
Comment on lines
177
to
+181
if(secret_chance && (prob(1))) | ||
InitializeSecretIcon() | ||
|
||
if(SSmaptype.chosen_trait == FACILITY_TRAIT_JOKE_ABNOS && secret_chance) | ||
InitializeSecretIcon() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh i think this would be cleaner
Suggested change
if(secret_chance && (prob(1))) | |
InitializeSecretIcon() | |
if(SSmaptype.chosen_trait == FACILITY_TRAIT_JOKE_ABNOS && secret_chance) | |
InitializeSecretIcon() | |
if(secret_chance && (prob(1) || SSmaptype.chosen_trait == FACILITY_TRAIT_JOKE_ABNOS)) | |
InitializeSecretIcon() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Station Traits now only appear in 50% of all rounds instead of 11%.
-Legacy Pale Trait has been removed.
-Selection Mishap has been removed. While some people like this one, and it's not as hated, it's quite polarizing so
-Abno Blitz weight has been reduced from 5 to 3 weight. It's very polarizing so it's important to keep it low. Some people love it, and some people hate it.
-Joke Abnormalities now Guarantees alternate joke sprites
-Wounds now actually works in the callback trait. This trait is also rather polarizing so it may be removed.
-Working clerks had it's rate reduced from 3 to 2
-Added experimental departmental agents station trait, people have been bitching about it for forever, so testing it as a trait is a good idea. May or may not stick around
Why It's Good For The Game
A small rebalance of Station Traits.
Initial feedback is generally positive, however the system as a whole needs changing to have players like it more.
Removing less liked traits, and making tweaks to other traits.
Changelog
🆑
balance: rebalanced station traits
/:cl: