Fire damage Overhaul #2710
Open
Fire damage Overhaul #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coxswain-Navigator
added
Balance
Coxswain-Navigator
force-pushed
the
fire-damage-rework
branch
from
4e93b63 to
616f521
Compare
Kitsunemitsu
reviewed
Feb 3, 2025
Coxswain-Navigator
force-pushed
the
fire-damage-rework
branch
6 times, most recently
from
99a7b9f to
9b3f86e
Compare
|
I have a genuine question. Why don't we have a flat 0 burn defense and then specific armors increase it? I don't see any reason to add a 5th armor value to EVERY SINGLE armor. |
Coxswain-Navigator
force-pushed
the
fire-damage-rework
branch
from
9b3f86e to
a8ce591
Compare
Burn damage "already" exists as a damage type in a only half-implemented state. We did have a lengthy conversation on this... |
Coxswain-Navigator
force-pushed
the
fire-damage-rework
branch
from
a8ce591 to
bff6c9c
Compare
some fixes should fix this stuff h first attempt at fixing linters adds some damage coeffs burn ouchey adds fire damage to firebird reworks this whole thing adds some text stuff fixes the damage formula
Coxswain-Navigator
force-pushed
the
fire-damage-rework
branch
from
bff6c9c to
df4a4b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
So fire damage is kind of all over the place. This PR fixes that. Mostly, at least. It took me way too long to figure out how carbons actually take damage.
Code Changes
Fixes
Balance Changes
Misc
Why It's Good For The Game
Making things more consistent is good, it's not great having burn work differently depending on its source. Like getting set on fire and taking red damage...
I'll tackle burn damage and resistances in a separate PR to keep things atomic.
Changelog
🆑
tweak: added burn/fire resistance to some E.G.O. Armors
balance: rebalanced burn damage in general
code: created a damage formula for burn/fire damage
/:cl: