forked from noir-lang/noir
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement From
array trait for BoundedVec
#2
Open
akonior
wants to merge
7
commits into
master
Choose a base branch
from
arek/bounded_vec_from_trait
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akonior
force-pushed
the
arek/bounded_vec_from_trait
branch
from
April 25, 2024 10:15
946191a
to
03e204c
Compare
akonior
changed the title
Implement the From trait for array to BoundedVec conversion
feat: implement the From trait for array to BoundedVec conversion
Apr 25, 2024
akonior
changed the title
feat: implement the From trait for array to BoundedVec conversion
feat: implement Apr 25, 2024
From[T; ArrayLen]
trait for BoundedVec
akonior
changed the title
feat: implement
feat: implement Apr 25, 2024
From[T; ArrayLen]
trait for BoundedVec
From<[T; ArrayLen]>
trait for BoundedVec
akonior
changed the title
feat: implement
feat: implement Apr 25, 2024
From<[T; ArrayLen]>
trait for BoundedVec
From
array trait for BoundedVec
akonior
force-pushed
the
arek/bounded_vec_from_trait
branch
5 times, most recently
from
April 25, 2024 13:09
70bd2d4
to
9b54ce6
Compare
akonior
force-pushed
the
arek/bounded_vec_from_trait
branch
from
April 25, 2024 13:15
9b54ce6
to
8a8c2e3
Compare
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Implementing a concise, single-line method for converting arrays to BoundedVec would enhance usability.
Summary*
This pull request implements the
From
trait to enable array-to-BoundedVec conversions, allowing for the following usageinstead of:
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.