Circuits monorepo #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogvinovLeon
force-pushed
the
leo/benchmarks
branch
from
6296fb0 to
1ce7543
Compare
LogvinovLeon
force-pushed
the
leo/benchmarks
branch
from
1ce7543 to
ba7a090
Compare
LogvinovLeon
force-pushed
the
leo/benchmarks
branch
from
ba7a090 to
6cf61e5
Compare
LogvinovLeon
force-pushed
the
leo/benchmarks
branch
from
1a3d11e to
0ccdcd5
Compare
LogvinovLeon
force-pushed
the
leo/benchmarks
branch
from
8360280 to
f9e7f88
Compare
marekkirejczyk
approved these changes
Jan 31, 2024
| @@ -1 +1,4 @@ | |||
| node_modules | |||
| target | |||
| proofs | |||
| contract | |||
There was a problem hiding this comment.
Because they're autogenerated
| @@ -0,0 +1,27 @@ | |||
| name: circuit profiling | |||
|
|
|||
There was a problem hiding this comment.
Do we still need profiling?
There was a problem hiding this comment.
Yes. Ideally I would like to set up a system that will print +X% on every PR changing a circuit. This is a first step into this direction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can run nagro commands using either
--workspaceflag to run it in all circuits or--package Xto run a single package. You can also omit the flag and the main circuit will be the target.So you can do things like:
nargo info --workspacewhich will print you the table of circuit sizes.The plan for the next PR is to diff those results with main, post the diff and the results as the sticky comment