-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get storage recursive proof #330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akonior
force-pushed
the
arek/get_storage_recursive
branch
from
June 7, 2024 08:24
5e66924
to
47113f1
Compare
akonior
force-pushed
the
arek/get_storage_recursive
branch
from
June 7, 2024 09:01
e1a10ae
to
b036fd8
Compare
akonior
force-pushed
the
arek/get_storage_recursive
branch
from
June 7, 2024 09:03
b036fd8
to
c800523
Compare
akonior
force-pushed
the
arek/get_storage_recursive
branch
from
June 7, 2024 09:17
c800523
to
0894363
Compare
akonior
force-pushed
the
arek/get_storage_recursive
branch
from
June 7, 2024 09:49
0894363
to
7fae049
Compare
akonior
force-pushed
the
arek/get_storage_recursive
branch
from
June 10, 2024 08:32
88c63c9
to
79db2cb
Compare
akonior
force-pushed
the
arek/get_storage_recursive
branch
from
June 10, 2024 10:06
d8017e5
to
acf26e2
Compare
LogvinovLeon
approved these changes
Jun 10, 2024
fn success() { | ||
let result = StorageWithinBlock { block_hash: hash, account, values }; | ||
// This is not a correct proof but it passes because nargo does not verify it. Nargo thinks that it's bb's job, but doesn't call bb. | ||
let recursive_proof = RecursiveProof { proof: zeroed(), verification_key: zeroed(), key_hash: zeroed() }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use zeroed on the whole struct once instead of using on each field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
akonior
force-pushed
the
arek/get_storage_recursive
branch
from
June 10, 2024 10:43
acf26e2
to
6d4d142
Compare
akonior
force-pushed
the
arek/get_storage_recursive
branch
from
June 10, 2024 10:46
6d4d142
to
ee46af8
Compare
aajj999
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.