Cleanup legacy constants after merkle_patricia_proofs migration #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasifaee
force-pushed
the
iza/rm_legacy_code
branch
from
71c280f to
2868244
Compare
Pasifaee
force-pushed
the
iza/rm_dead_code
branch
2 times, most recently
from
0d70d62 to
6179a75
Compare
Pasifaee
force-pushed
the
iza/rm_legacy_code
branch
from
2868244 to
ad8d05b
Compare
Pasifaee
force-pushed
the
iza/rm_legacy_code
branch
from
ad8d05b to
b770e00
Compare
Pasifaee
force-pushed
the
iza/rm_legacy_code
branch
from
b770e00 to
3d0c59b
Compare
Pasifaee
changed the title
Pasifaee
changed the title
LogvinovLeon
approved these changes
May 31, 2024
akonior
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the code that was previously marked as legacy. It updates
MAX_RECEIPT_ENCODED_LENandMAX_TX_ENCODED_LENfrom 525 which is a legacy value to 1000 which is an M size for receipts and transactions. It's a PR on top of #318