Migrate transactions to merkle_patricia_proofs library #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasifaee
force-pushed
the
iza/tx_migration
branch
from
2bc3b7c to
aa4b212
Compare
aajj999
requested changes
May 24, 2024
| @@ -165,6 +165,7 @@ impl Serde<RECEIPT_PROOF_LEN_M> for Proof<RECEIPT_MAX_DEPTH_NO_LEAF, RECEIPT_MAX | |||
| } | |||
|
|
|||
| global RECEIPT_PROOF_INPUT_LEN_M = RECEIPT_MAX_PREFIXED_KEY_NIBBLE_LEN + RECEIPT_MAX_VALUE_LEN_M + RECEIPT_PROOF_LEN_M; | |||
| global TX_PROOF_INPUT_LEN_M = RECEIPT_PROOF_INPUT_LEN_M; | |||
|
|
|||
| impl Serde<RECEIPT_PROOF_INPUT_LEN_M> for ProofInput<RECEIPT_MAX_PREFIXED_KEY_NIBBLE_LEN, RECEIPT_MAX_VALUE_LEN_M, RECEIPT_MAX_DEPTH_NO_LEAF, RECEIPT_MAX_LEAF_LEN_M> { | |||
| fn serialize(self) -> [Field; RECEIPT_PROOF_INPUT_LEN_M] { | |||
There was a problem hiding this comment.
It would be also clearer if we used a common length here instead of receipt.
|
|
||
| const proofInputKeyPart = txWithProof[OFFSETS.PROOF_INPUT].slice(0, txProofConfigM.maxPrefixedKeyNibbleLen); | ||
| const paddedKey = padArray(['0x08'], txProofConfigM.maxPrefixedKeyNibbleLen, ZERO_PAD_VALUE, 'left'); | ||
| expect(proofInputKeyPart).toStrictEqual(paddedKey); |
There was a problem hiding this comment.
Aren't we losing here some testing?
There was a problem hiding this comment.
You're right, I will add tests
aajj999
approved these changes
May 24, 2024
Pasifaee
force-pushed
the
iza/tx_migration
branch
from
c7c57a8 to
c51f8b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.