Remove authors #304
Merged
Remove authors #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekkirejczyk
approved these changes
May 23, 2024
LogvinovLeon
force-pushed
the
leo/remove_authors
branch
from
78663ac to
0515786
Compare
marekkirejczyk
approved these changes
May 23, 2024
ethereum/circuits/lib/Nargo.toml
Outdated
| @@ -1,7 +1,6 @@ | |||
| [package] | |||
| name = "ethereum" | |||
| type = "lib" | |||
| authors = ["Arkadiusz Konior, Marek Kirejczyk"] | |||
There was a problem hiding this comment.
Or should we mention vlayer team or just name all commiters?
There was a problem hiding this comment.
Naming all commiters is is a PITA as people join. And I don't see a point. We can write "vlayer" there, but it's already in the vlayer repo, it will be published by our account and in our namespace. Don't see a point of this field except for when the library is authored by one or two authors. I think it makes sense when you list e-mails of the authors so that you can e-mail them about issues, but it's some 1992 thinking
LogvinovLeon
force-pushed
the
leo/remove_authors
branch
from
ae00d45 to
190b071
Compare
LogvinovLeon
force-pushed
the
leo/remove_authors
branch
from
190b071 to
d1a6e25
Compare
LogvinovLeon
force-pushed
the
leo/remove_authors
branch
from
d1a6e25 to
a077ae2
Compare
ethereum/oracles/package.json
Outdated
| @@ -21,8 +21,7 @@ | |||
| "prepare-js-fixtures": "tsx src/script/prepareJSHistoryAPIFixtures", | |||
| "prepare-noir-fixtures": "rm -rf ../circuits/lib/src/fixtures && tsx src/script/prepareNoirHistoryAPIFixtures && tsx src/script/prepareMerkleProofFixtures" | |||
| }, | |||
| "author": "", | |||
| "license": "MIT", | |||
| "license": "ISC", | |||
akonior
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.