Deserialize function in a Serde trait #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajj999
requested changes
May 9, 2024
|
|
||
| fn deserialize(data: [Field; ACCOUNT_WITHIN_BLOCK_SERIALIZED_LEN]) -> Self { | ||
| let mut fragment = Fragment::new_focused(data); | ||
| let account: Account = Account::deserialize(fragment.pop_front_array()); |
There was a problem hiding this comment.
It's worth explaining somewhere in the file why we need to call deserialise with type here (as opposite to case with BYTES32) and probably make an issue to noir out of it.
There was a problem hiding this comment.
noir-lang/noir#5005
Preparing repro for another one now
|
|
||
| impl Serde<ACCOUNT_WITHIN_BLOCK_SERIALIZED_LEN> for AccountWithinBlock { | ||
| fn serialize(self) -> [Field; ACCOUNT_WITHIN_BLOCK_SERIALIZED_LEN] { | ||
| let mut data: Fragment<ACCOUNT_WITHIN_BLOCK_SERIALIZED_LEN, Field> = Fragment::empty(); |
There was a problem hiding this comment.
I think for serialization you can use BoundedVec, no need for Fragment. #BoundedVec
marekkirejczyk
approved these changes
May 10, 2024
aajj999
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of #263
This PR adds a deserialize function in a Serde trait alongsize the serialize counterparty.
This allows us to pass complex values through oracle without hitting: noir-lang/noir#4561
Without it - I wasn't able to return our StorageWithinBlock struct from an Oracle