Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac CMD+F does not work #87

Closed
tombarys opened this issue Dec 26, 2018 · 10 comments
Closed

Mac CMD+F does not work #87

tombarys opened this issue Dec 26, 2018 · 10 comments
Labels
enhancement

Comments

@tombarys
Copy link

Hi, Cmd+F shortcut does not work. I am frequently adding and using e-mail filters and I need to search through the page with them to skip to them quickly. Is any way how to do it?
Thanks in advance!
Tomáš
@vladimiry
Copy link
Owner

The requested feature is not implemented at this moment.

@tombarys
Copy link
Author

tombarys commented Dec 26, 2018 via email

@vladimiry
Copy link
Owner

vladimiry commented Dec 29, 2018 •
edited
Loading

The pre v2.1.0 version with Cmd+F feature included is uploaded here. This version also got #86 resolved.

Electron doesn't provide a complete built-in solution for Cmd+F thing. My implementation is a bit tricky and there is an issue I'm still to sort out: when I was testing the feature the app process got hanged a few times with high CPU use and I had to kill the process. It seems to be working in general but I'm interested in revealing possible issues apart of the hanged app process. @tombarys, can you try it?

The feature is disabled by default as for now and marked with experimental label due to the above-mentioned issue.

See how to enable the feature:

peek3

@vladimiry
Copy link
Owner

I figured why the process was hanging, no easy fix available though.

@tombarys
Copy link
Author

tombarys commented Dec 29, 2018 via email

@tombarys
Copy link
Author

tombarys commented Dec 29, 2018 via email

@vladimiry
Copy link
Owner

  • CMD-A (for selecting "all") too for editing in forms (search etc.) and especially when deleting whole email ...

Opened separate issue #90.

@vladimiry
Copy link
Owner

The in page search feature now works as the following:

  • Feature is only available within account's page. So if you have no accounts added to the app then Ctrl+F hotkey will take no effect.
  • The search window will be automatically closed on switching between accounts.
  • Search window will be automatically closed on switching to the database view mode. Ctrl+F hotkey takes no effect while in database view mode. Database view mode is going to get its own full-text search, one day.
  • The main app process doesn't hang anymore. It was hanging because findInPage hangs trying to highlight matches in invisible webview. Unfortunately webview can't be taken out from DOM as it gets reloaded if re-attached back to DOM (another Electron's issue). In my opinion it should not search through the hidden elements in the first place. Currently Electron doesn't provide an option to explicitly filter out some elements from searching (like by CSS selector), see respective issue.

Build uploaded here has been updated. @tombarys can you try it? If it works well and as described, then I think this is going to be a settled for the next release implementation.

TextExpander

What is TextExpander, screesnhot?

@vladimiry vladimiry mentioned this issue Dec 30, 2018
Closed
@tombarys
Copy link
Author

tombarys commented Jan 1, 2019 via email

@vladimiry
Copy link
Owner

The TextExpander is an app used for text expansions – https://textexpander.com/download/.

At this moment I don't have the capacity to support third-party tools, but you can open a separate issue if you want.

Closing as resolved. The feature will be a part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vladimiry @tombarys