Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): bump rjb to newer version #45

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

vseguin
Copy link
Contributor

@vseguin vseguin commented Apr 19, 2024

Confirmed it fixes #44.

Seems like there's no other changes required from what I can see.

@vkononov
Copy link
Owner

@vseguin Thanks for the pull request, but I'm confused - the issue indicated that the gem only works with [email protected] but your pull request updates rjb to 1.7, which is confirmed not to be compatible with this gem.

@vseguin
Copy link
Contributor Author

vseguin commented Apr 19, 2024

@vseguin Thanks for the pull request, but I'm confused - the issue indicated that the gem only works with [email protected] but your pull request updates rjb to 1.7, which is confirmed not to be compatible with this gem.

Makes sense, I tested and my use case worked but I'm happy to just hardcode to 1.6.9?

@vseguin
Copy link
Contributor Author

vseguin commented Apr 19, 2024

@vseguin Thanks for the pull request, but I'm confused - the issue indicated that the gem only works with [email protected] but your pull request updates rjb to 1.7, which is confirmed not to be compatible with this gem.

Makes sense, I tested and my use case worked but I'm happy to just hardcode to 1.6.9?

Done that actually.

@vseguin
Copy link
Contributor Author

vseguin commented Apr 30, 2024

@vkononov any desire to merge this one? :)

@vkononov
Copy link
Owner

Sorry for the delay. Instead of hardcoding a specific version, can you change it to:

spec.add_runtime_dependency 'rjb', '~> 1.6.0'

This way, people can continue use it with @[email protected].

Thanks!

@vseguin
Copy link
Contributor Author

vseguin commented Apr 30, 2024

Sorry for the delay. Instead of hardcoding a specific version, can you change it to:

spec.add_runtime_dependency 'rjb', '~> 1.6.0'

This way, people can continue use it with @[email protected].

Thanks!

@vkononov sure, done!

@vkononov
Copy link
Owner

You're very fast! Thanks, Vincent!

@vkononov vkononov merged commit 77e061f into vkononov:master Apr 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constantly getting NoSuchField error on new setup
2 participants