Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes various font issues related to the document viewer, manuscript preview, and PDF output. These all use the same ToQTextDocument converter class. They have various font-related issues. The cause was the font matching algorithm in Qt5 being lazy and replacing fonts when changes were made in Preferences, and letting them replace the chose build settings font. A helper function now tries to overcome this, if it can. It seems to work,
This PR also fixes some minor issues in the ODT output, and fixes a bug related to resetting to regular/normal font style when using emphasis in the text, instead of the chosen default style. This only affected the ToQTextDocument converter.
Related Issue(s):
Closes #2121
Closes #2118
Related #2110
Reviewer's Checklist: