Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite narrator break for dialogue highlighting #2068

Merged
merged 5 commits into from
Oct 27, 2024
Merged

Rewrite narrator break for dialogue highlighting #2068

merged 5 commits into from
Oct 27, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Oct 27, 2024

Summary:

This PR rewrites the RegEx-based narrator break highlighting for dialogue with a string-split based one that better handles the various use cases.

Related Issue(s):

Closes #2066

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.6 Beta 1 milestone Oct 27, 2024
@vkbo vkbo merged commit 07c700f into main Oct 27, 2024
9 checks passed
@vkbo vkbo deleted the narrator_break branch October 27, 2024 12:15
@vkbo vkbo changed the title Rewriter narrator break for dialogue highlighting Rewrite narrator break for dialogue highlighting Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support narrator breaks in PT-BR in dialogue highlighting
1 participant