Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in the document viewer #2014

Merged
merged 3 commits into from
Sep 1, 2024
Merged

Fix bugs in the document viewer #2014

merged 3 commits into from
Sep 1, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Sep 1, 2024

Summary:

This PR fixes a number of bugs with the new document viewer in 2.5:

  • Tab stop distances are now properly set after a document is loaded. Loading a new document resets it to default value, and need to be updated.
  • The Tokenizer can now properly handle multiple formatting markers that are set on the same character location. Previously, the order of the position-sorted markers would affect whether they came out correctly or not.
  • The Tokenizer now only applies dialogue highlighting to plain text paragraphs in novel documents. Previously, the viewer would highlight all quotes as dialog.

Related Issue(s):

Closes #1996
Closes #2011
Closes #2012
Closes #2013

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5.2 milestone Sep 1, 2024
@vkbo vkbo merged commit 095c005 into release Sep 1, 2024
8 checks passed
@vkbo vkbo deleted the viewer_fixes branch September 1, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant