Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows packaging #1932

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Update Windows packaging #1932

merged 2 commits into from
Jun 14, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jun 14, 2024

Summary:

This PR updates the Windows packaging config file with a few improvements, and solves two warnings raised by the lates Inno Setup. It also switches from lzma compression to zip, which increases package size, but hopefully reduces the chance of false positives with Windows Defender and other scanners who more and more rely on ML, which is prone to false positives.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 RC 1 milestone Jun 14, 2024
@vkbo vkbo merged commit 2196486 into main Jun 14, 2024
8 checks passed
@vkbo vkbo deleted the win_installer branch June 14, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant