Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend dialogue highlighting #1908

Merged
merged 18 commits into from
Jun 10, 2024
Merged

Extend dialogue highlighting #1908

merged 18 commits into from
Jun 10, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jun 1, 2024

Summary:

This PR:

  • Limits dialogue highlighting to only apply to novel documents, not project notes.
  • Moves the regex pattern generation for text format processing to a new class and module for easier sharing.
  • Adds processing of dialogue recognition patterns to the Tokenizer class.
  • Adds formatting of dialogue to the QTextDocument generator class, and thus the document viewer.
  • Adds formatting of dialogue to ODT and HTML output, controlled via a new switch in Build Settings.

Related Issue(s):

Closes #1774

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 RC 1 milestone Jun 1, 2024
@vkbo vkbo merged commit cc61c53 into main Jun 10, 2024
8 checks passed
@vkbo vkbo deleted the dialogue_highlight branch June 10, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend dialogue highlighting
1 participant