Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR makes the following improvements to the Tokenizer class:
T_TEXT
is a whole paragraph. A setting flag determines whether the line break is preserved or replaced with a single space. Each format class must ensure any line breaks in this text is handled correctly.T_EMPTY
token entries passed on to the format classes. These are now stripped in the second pass over the token list when paragraphs lines are combined.This text line combining logic is identical to the one that was used in the ODT writer class, with a single optimisation that the recalculation of formatting positions is skipped if the paragraph contains a single line.
Related Issue(s):
Needed for #1882
Reviewer's Checklist: