Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error text colour setting to theme #1880

Merged
merged 5 commits into from
May 20, 2024
Merged

Add error text colour setting to theme #1880

merged 5 commits into from
May 20, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented May 20, 2024 •
edited
Loading

Summary:

This PR adds a new error text colour setting to the themes definition. This is used to fix an issue with the dictionary install tool.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 Beta 1 milestone May 20, 2024
@vkbo vkbo merged commit 0bc8a63 into main May 20, 2024
8 checks passed
@vkbo vkbo deleted the fix/dict_tool_error_colour branch May 20, 2024 11:36
@vkbo vkbo changed the title Add error text colur setting to theme Add error text colour setting to theme May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.5 Beta 1
Development

Successfully merging this pull request may close these issues.
1 participant
@vkbo