Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context menu entry to set item name from heading #1614

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 23, 2023

Summary:

This PR:

  • Changes some of the logic in editor and viewer to use proper signals to communicate with other components.
  • Cleans up the enums in the editor and viewer.
  • Adds a context menu entry in the editor to rename a document from a heading in the text.
  • Adds test coverage of the context menu.

Related Issue(s):

Closes #1503

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.2 RC 1 milestone Nov 23, 2023
@vkbo vkbo linked an issue Nov 23, 2023 that may be closed by this pull request
@vkbo vkbo merged commit b7eede2 into dev Nov 23, 2023
9 checks passed
@vkbo vkbo deleted the title_and_label branch November 23, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changing scene title and item name simultaneously
1 participant