Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set menu parents #1572

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Set menu parents #1572

merged 1 commit into from
Nov 4, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 4, 2023

Summary:

This PR adds a parent item to all QMenu constructors. This can help with the positioning issue according to QTBUG-68636.

The remaining issue is a know issue with Qt5 on Wayland, and is not likely to be fixed. Moving to Qt6 (#1142) is the more likely solution, which will have to wait.

Related Issue(s):

Closes #1536

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.1.1 milestone Nov 4, 2023
@vkbo vkbo merged commit a50e79b into main Nov 4, 2023
@vkbo vkbo deleted the menu_parents branch November 4, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menus open in a weird spot (Linux AppImage, Debian 12)
1 participant