Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling of spell checking #1508

Merged
merged 6 commits into from
Aug 25, 2023
Merged

Refactor handling of spell checking #1508

merged 6 commits into from
Aug 25, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Aug 24, 2023

Summary:

This PR:

  • Moves the spell check instance to the new shared data class, so that the object can be destroyed and re-created with the project.
  • Cleans up loading of the user's own custom dictionary, which is per-project and must be handled correctly to prevent bleed-through between projects.
  • Adds a way to change spell check language from the Tools menu.

Also:

  • The project class is no longer a subclass of QObject.
  • Various attributes of core classes have been converted to properties.
  • The syntax highlighter class has received a cleanup.

Related Issue(s):

Closes #1260

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.1 Beta 2 milestone Aug 24, 2023
@vkbo vkbo linked an issue Aug 25, 2023 that may be closed by this pull request
@vkbo vkbo merged commit 1b98bdf into dev Aug 25, 2023
@vkbo vkbo deleted the spelling branch August 25, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set spell check language from status bar
1 participant