Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build settings tool #1499

Merged
merged 12 commits into from
Aug 6, 2023
Merged

Improve build settings tool #1499

merged 12 commits into from
Aug 6, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Aug 6, 2023

Summary:

This PR makes the following changes to the Build Settings tool:

  • Improves the distinction between a clickable item and a section label in the paged side bar widget.
  • Changes the name of the "Filters" tab to "Selection".
  • Changes the icon for the filtered item from a filter symbol to the arrow used for the build icon.
  • Changes the icon on the "Filtered" button to a revert/undo type icon and changes the tooltip to "Revert to default", and move it to after the other two buttons.
  • Adds tooltips to the selection icons in the tree.
  • Changes the label for "Document Types" to "Document Filters"
  • Changes the label for "Root Folders" to "Select Root Folders"
  • Changes the behaviour of the reset/include/exclude button when a single, non-document item is selected to recursively apply the chosen state to all child items.
  • Adds file extensions to the headers on the "Output" tab.
  • Fixes processing of line breaks in headers in the build formats.
  • Changes the behaviour of the page size settings so that it doesn't block the spin boxes, but rather flips the preset to "Custom" when the user manually changes the units.
  • Adds logic to ensure when a page size preset is selected, the page size values are reset when units are changed. Otherwise, the values would drift due to round-off when moving between cm or mm and inches.
  • Makes the build settings dialog a child of the main GUI instead of the build tool, which means either one can be on top of the other.
  • Adds a check that a build settings dialog isn't already open for a given build before another one is created.

Related Issue(s):

Closes #1497

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.1 Beta 2 milestone Aug 6, 2023
@vkbo vkbo merged commit c3b3120 into dev Aug 6, 2023
@vkbo vkbo deleted the build_settings branch August 6, 2023 21:08
@vkbo vkbo linked an issue Aug 6, 2023 that may be closed by this pull request
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Settings improvements
1 participant