Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lxml #1452

Merged
merged 11 commits into from
May 29, 2023
Merged

Remove lxml #1452

merged 11 commits into from
May 29, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented May 29, 2023

Summary:

This PR:

  • Replaces lxml with Python standard library xml package in the Project XML read/write classes.
  • Replaces lxml with Python standard library xml package in the ODT writer class.
  • Adds a custom xml indent function based on the one from the standard library. This one behaves more closely to how the indentation from lxml was added. In particular, it allows inline elements that do not have line breaks by explicitly requiring that text and tail attributes are set to None before breaks are added.
  • Update all test and test reference files.
  • Drop CI for Python 3.7, but Python 3.7 support itself is not yet officially dropped. It will likely be dropped before 2.1 is released though.
  • Remove all references to the lxml package in the source, install files, documentation, and tests.

Related Issue(s):

Closes #1257

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.1 Beta 1 milestone May 29, 2023
@vkbo vkbo linked an issue May 29, 2023 that may be closed by this pull request
@vkbo vkbo merged commit b7eb4d3 into dev May 29, 2023
@vkbo vkbo deleted the remove_lxml branch May 29, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace lxml with standard library xml
1 participant