Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR rewrites how the global CONFIG object is handled during testing. It is no longer mocked and replaced by a test config object, but is instead reset before each test is run. This means there is no need to assign the global CONFIG object to a class attribute at the initialisation of a class so it can be overridden in the tests. Since the CONFIG object is created immediately on first import, it is very tricky to mock.
With this change, CONFIG is accessed directly wherever access to the user's config settings are needed. This should also be marginally faster, as the object is no longer stored in a class dictionary, which adds a bit of overhead when accessing it.
Related Issue(s):
Reviewer's Checklist: