Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spell check refresh (for small documents) #1416

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Apr 13, 2023

Summary:

This PR resolves an issue where turning off automatic spell checking does not clear spell checking marks in the text. This only works for "small" documents (smaller than the "big document limit" in settings). For big documents, all spell checking refresh is done manually.

Related Issue(s):

Closes #1414

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.0.7 milestone Apr 13, 2023
@vkbo vkbo merged commit 239bc88 into main Apr 13, 2023
@vkbo vkbo deleted the fix/toggle_spell_check branch April 13, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deactivating "Check Spelling" does not remove visual indicators
1 participant