Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyQt5 version check #1325

Merged
merged 3 commits into from
Jan 29, 2023
Merged

Fix PyQt5 version check #1325

merged 3 commits into from
Jan 29, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jan 29, 2023

Summary:

Seems QT_VERSION_STR has been imported from a different location than what's listed in the PyQt5 documentation. It may have moved at some point, or the import from PyQt5.Qt may have been a bleed through that is no longer there.

This PR imports it from PyQt5.QtCore instead, as the PyQt5 docs state. The PR also replaces the 10 base integer version with the hex version provided by PyQt5. There is only one version check left in the main code anyway.

Related Issue(s):

Resolves #1324

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.0.4 milestone Jan 29, 2023
@vkbo vkbo linked an issue Jan 29, 2023 that may be closed by this pull request
@vkbo vkbo changed the title Fix/version check Fix PyQt5 version check Jan 29, 2023
@vkbo vkbo merged commit fe6d4de into patch Jan 29, 2023
@vkbo vkbo deleted the fix/version_check branch January 29, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyQt version import error prevents application from launching
1 participant