Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Seems
QT_VERSION_STR
has been imported from a different location than what's listed in the PyQt5 documentation. It may have moved at some point, or the import fromPyQt5.Qt
may have been a bleed through that is no longer there.This PR imports it from
PyQt5.QtCore
instead, as the PyQt5 docs state. The PR also replaces the 10 base integer version with the hex version provided by PyQt5. There is only one version check left in the main code anyway.Related Issue(s):
Resolves #1324
Reviewer's Checklist: