Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trash folder fixes and Notice Bar #106

Merged
merged 5 commits into from
Oct 31, 2019
Merged

Trash folder fixes and Notice Bar #106

merged 5 commits into from
Oct 31, 2019

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Oct 31, 2019

This PR adds a read only flag to documents that the document editor class respects. This is in particular used to prevent the editing of files in the trash folder.

The PR also ensures that new items cannot be added to the trash folder and the orphaned files folder.

To notify the user that the file is read only, a notice bar will pop up at the top of the editor letting them know the file is read only. The notice can be dismissed.

These changes resolve issue #105

Also in this PR:

  • Split the source files in the ever growing gui folder into a few sub folders.
  • Slightly adjusted the margins of the main window such that all content between menu and status bar has a 4 pixel margin, and the margin of the treeview pane has been removed.

@vkbo vkbo merged commit 60ed451 into master Oct 31, 2019
@vkbo vkbo deleted the trash_folder branch November 2, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant