Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug with status icon in GUI Default Light Theme #2057

Closed
mm47 opened this issue Oct 20, 2024 · 1 comment · Fixed by #2059
Closed

Minor bug with status icon in GUI Default Light Theme #2057

mm47 opened this issue Oct 20, 2024 · 1 comment · Fixed by #2059
Labels
bug Issue: Something isn't working user interface Component: General user interface
Milestone

Comments

@mm47
Copy link

mm47 commented Oct 20, 2024

The Editor and Project circle icons get color red when everything is saved, and green when there are unsaved changes. This happens only in Default Light Theme in version 2.5.2 (appimage downloaded from github), the Default Dark Theme and all the other themes work properly (green when saved, red when unsaved).

With version 2.1, the icons work properly with all themes, but version 2.1.1 introduces the bug with all themes. Then in version 2.2 everything works properly again. Things remain okay in version 2.3.1, but the bug reappears in version 2.4.4.

All tests have been done with the appimages. I can't test with the debian packages because my system is based on Ubuntu 20.04 and there are some unresolvable dependencies (not the issue here).

@mm47 mm47 added the bug Issue: Something isn't working label Oct 20, 2024
@vkbo vkbo added the user interface Component: General user interface label Oct 20, 2024
@vkbo vkbo added this to the Release 2.5.3 milestone Oct 20, 2024
@vkbo
Copy link
Owner

vkbo commented Oct 20, 2024

Yes, I can see it in the theme file too. These are the r, g, b values:

assets/themes/default_dark.conf

statusnone      = 150, 152, 150
statussaved     =  39, 135,  78
statusunsaved   = 138,  32,  32

assets/themes/default_light.conf

statusnone      = 120, 120, 120
statussaved     = 200,  15,  39
statusunsaved   =   2, 133,  37

I have never noticed myself as I don't use the light theme. Thanks for pointing it out. I'll make a fix for it.

@vkbo vkbo linked a pull request Oct 21, 2024 that will close this issue
6 tasks
@vkbo vkbo closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Something isn't working user interface Component: General user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants