Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock file in the project folder is staying behind when it should be removed. #1977

Closed
arnehemingway opened this issue Jul 14, 2024 · 2 comments · Fixed by #1978
Closed

Lock file in the project folder is staying behind when it should be removed. #1977

arnehemingway opened this issue Jul 14, 2024 · 2 comments · Fixed by #1978
Labels
bug Issue: Something isn't working investigate Meta: Requires further investigation
Milestone

Comments

@arnehemingway
Copy link

arnehemingway commented Jul 14, 2024

Hi,
I use the novelWriter AppImage on multiple machines and they all point to a project on shared storage. Yesterday I updated one machine to 2.5 and worked on my project. Today, I opened that same project on another machine using 2.4.3 and received a warning about opening a project created with a newer version of novelWriter.
image
I chose "no", exited novelWriter in normal fashion, switched to the new AppImage and was presented with the "another instance is running" warning, showing the hostname and OS of the machine I was on and dated moments earlier.
image

I think that, when answering "no" to the first dialog above, the lock file should be removed from the project directory.

I realize that this is a very minor issue. I bring it to your attention more as a service to you than anything else.

@arnehemingway arnehemingway added the bug Issue: Something isn't working label Jul 14, 2024
@vkbo
Copy link
Owner

vkbo commented Jul 14, 2024

It could be the lockfile is created too early. I'll investigate.

@vkbo vkbo added the investigate Meta: Requires further investigation label Jul 14, 2024
@vkbo vkbo added this to the Release 2.5.1 milestone Jul 14, 2024
@vkbo
Copy link
Owner

vkbo commented Jul 14, 2024

Yes, the lock file is created when the project session object is successfully initiated, but before a number of other checks, including the project format upgrade/downgrade checks. I've rewritten it so that the project is not lucked during initialisation, but after a completed project open process.

@vkbo vkbo linked a pull request Jul 14, 2024 that will close this issue
6 tasks
@vkbo vkbo closed this as completed Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Something isn't working investigate Meta: Requires further investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants