Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Tool: Indent First Paragraph #1965

Closed
awqk opened this issue Jul 6, 2024 · 10 comments · Fixed by #1971
Closed

Build Tool: Indent First Paragraph #1965

awqk opened this issue Jul 6, 2024 · 10 comments · Fixed by #1971
Labels
bug Issue: Something isn't working
Milestone

Comments

@awqk
Copy link

awqk commented Jul 6, 2024

What's this setting supposed to do?

I don't see a difference in the preview (2.5 RC1).

@vkbo
Copy link
Owner

vkbo commented Jul 6, 2024

Please use discussions to ask questions.

But to answer it, it also enables first line indentation for the first paragraph in a new section. This is not commonly done in English, but apparently it is in for instance Chinese (according to the feature request).

@vkbo vkbo closed this as not planned Won't fix, can't repro, duplicate, stale Jul 6, 2024
@awqk
Copy link
Author

awqk commented Jul 7, 2024

#! title

### first scene

the first line of this paragraph is always indented, even with indent first paragraph disabled.

@vkbo
Copy link
Owner

vkbo commented Jul 7, 2024

Ok?

image

@vkbo
Copy link
Owner

vkbo commented Jul 7, 2024

Also, if it was a bug report, please say so. It didn't look like it was.

@awqk
Copy link
Author

awqk commented Jul 7, 2024

gnome-shell-screenshot-36q7cy

@awqk
Copy link
Author

awqk commented Jul 7, 2024

Ok, it works while in the same file, it doesn't when there are different files.

Didn't know what to expect, hence no bug report.

@vkbo
Copy link
Owner

vkbo commented Jul 7, 2024

Yes, so it is not the example you posted, which worked just fine. You've found some corner case, which is indeed a bug report.

@vkbo vkbo reopened this Jul 7, 2024
@vkbo vkbo added the bug Issue: Something isn't working label Jul 7, 2024
@vkbo vkbo added this to the Release 2.5 milestone Jul 7, 2024
@vkbo
Copy link
Owner

vkbo commented Jul 7, 2024

Since each document is processed separately, there may be some unexpected variable reset somewhere. It does work if you add a second scene though.

@awqk
Copy link
Author

awqk commented Jul 7, 2024

Sorry, didn't expect my example would work, so next time, I will test before posting.

@vkbo
Copy link
Owner

vkbo commented Jul 7, 2024

Ah, I see what is happening. The indentation is added in the second parsing pass, while headings are parsed on the first pass. So when the scene title is hidden and at the top of a file, the title entry, which disables the indentation, is not present on the second pass, so it defaults to indent if indentation is otherwise enabled.

If you turn on titles for scenes, it works as expected. In the single file case, the indentation is switched off due to the #! Title part, not the ### Scene heading.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants