Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Go to Document" is able to remove focus from document #1950

Closed
HeyMyian opened this issue Jun 28, 2024 · 1 comment · Fixed by #1954
Closed

"Go to Document" is able to remove focus from document #1950

HeyMyian opened this issue Jun 28, 2024 · 1 comment · Fixed by #1954
Labels
bug Issue: Something isn't working user interface Component: General user interface
Milestone

Comments

@HeyMyian
Copy link
Contributor

Reproduce:

  1. Open a document in the Editor.
  2. If the Document Viewer is open, close it.
  3. Focus the Editor.
  4. View -> Go to Document.

Contrary to what it says, this will remove the focus from the Editor. If Editor and Document Viewer are open side by side, this toggles between the two panels. But if only one of them is open, "Go to Document" will toggle focus on and off without anything else (to my knowledge?) gaining focus.

I suggest that in this case, the Editor or Document Viewer will simply keep their focus.

@HeyMyian HeyMyian added the bug Issue: Something isn't working label Jun 28, 2024
@vkbo
Copy link
Owner

vkbo commented Jun 29, 2024

It will still toggle to the viewer panel even if it's hidden, so this clearly needs an additional check.

The problem is that invisible items can have focus, as with the other bug you reported. It's not intuitive from a user's point of view, but these are entirely separate flags on a widget,

@vkbo vkbo added the user interface Component: General user interface label Jun 29, 2024
@vkbo vkbo added this to the Release 2.5 milestone Jun 29, 2024
@vkbo vkbo mentioned this issue Jul 3, 2024
6 tasks
@vkbo vkbo linked a pull request Jul 3, 2024 that will close this issue
6 tasks
@vkbo vkbo closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Something isn't working user interface Component: General user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants