Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial size of Manuscript Build Settings window #1551

Closed
HeyMyian opened this issue Oct 23, 2023 · 12 comments · Fixed by #1553
Closed

Initial size of Manuscript Build Settings window #1551

HeyMyian opened this issue Oct 23, 2023 · 12 comments · Fixed by #1553
Assignees
Labels
bug Issue: Something isn't working user interface Component: General user interface
Milestone

Comments

@HeyMyian
Copy link
Contributor

After the update (both beta and final) the first time the Manuscript Build Settings are opened, it has a funky width that is not wide enough to display any document names. This is easily helped by dragging the middle section wider. But maybe it should have a reasonable initial width.

This is on Windows. I can't remember if the same issue appeared on Linux.

2023-10-18___01_04_44
(ignore the missing icons)

@HeyMyian HeyMyian added the bug Issue: Something isn't working label Oct 23, 2023
@vkbo
Copy link
Owner

vkbo commented Oct 23, 2023

Hmm, it is set to size to content. I think maybe your issue is actually caused by the missing icons. There is a column of icons that are missing, and it seems to mess with the auto-sizing.

@HeyMyian
Copy link
Contributor Author

I've since fixed the icons (I think?) and the issue persists. It also seems to be per project that I need to resize the middle section.

2023-10-23___22_34_35

@vkbo
Copy link
Owner

vkbo commented Oct 23, 2023

The second and third column is set far too wide for some reason. It is hard coded to be fixed to icon width plus a small margin, but for some reason they're getting too much space. I'll look into it.

@vkbo
Copy link
Owner

vkbo commented Oct 23, 2023

Hmm, I tested on Windows 10, and the columns are wider than they should be, but not as wide as on your PC.

image

Do you by any chance have a high DPI screen?

@vkbo
Copy link
Owner

vkbo commented Oct 23, 2023

It also seems to be per project that I need to resize the middle section.

Yes, these settings are saved in meta/options.json in each project.

@HeyMyian
Copy link
Contributor Author

HeyMyian commented Oct 23, 2023

My screen has 109ppi (27″ 2560x1440). Currently there are two of them side by side active.

I just reset my novelWriter folders in Local and Roaming. This screenshot of a newly created project also has 10px UI font size compared to my previous 12px. The middle section is still too narrow and compared to your screenshot, the icon column takes up too much space?

2023-10-23___23_14_52

@vkbo
Copy link
Owner

vkbo commented Oct 23, 2023

Are you able to run novelWriter from source? I changed the minimum column width, and it reduced the size of the icon columns on my VM with Windows 10, so I was wondering if you can test it on yours.

@vkbo
Copy link
Owner

vkbo commented Oct 23, 2023

Basically, in the file novelwriter\tools\manussettings.py, insert the line:

treeHeader.setMinimumSectionSize(iPx + cMg)

So that it looks like this:

image

@vkbo vkbo self-assigned this Oct 23, 2023
@vkbo vkbo added the user interface Component: General user interface label Oct 23, 2023
@vkbo vkbo added this to the Release 2.1.1 milestone Oct 23, 2023
@HeyMyian
Copy link
Contributor Author

Yes, thank you. With your line added, this is what two new projects look like for my settings (dark) and with default settings (light). I think the right section could be the one who does the shrink in favor of the central section. But it's definitely much better now (if a bit crammed for the "included" icon?).

2023-10-23___23_39_26
2023-10-23___23_40_22

@vkbo
Copy link
Owner

vkbo commented Oct 23, 2023

Yeah, this is not theme related. I think the default minimum column width is different on each platform in Qt. I remember having to fix this for the project tree too, and I hadn't added that specific line in this dialog. I probably forgot why I added it elsewhere. This problem doesn't show up on my platform (Debian 12 + Gnome), so I never noticed.

There are a few minor issues around, so I'll do a 2.1.1 release very soon.

I'll also try to tune the initial size allocation for the splitter there. It should default to 50/50, but it clearly doesn't.

@HeyMyian
Copy link
Contributor Author

Thanks for taking care of this, and so fast too. It's really a non-issue from my point of view because it's easily fixed by just dragging the section wider once per project, and then it never occurs again. I thought I report it anyway for that certain software polish, to leave a better impression for first-time users.

@vkbo
Copy link
Owner

vkbo commented Oct 23, 2023

The icon column width is definitely a usability issue, if not exactly a bug. I'm guessing there are some design standards Qt is following or something. But it is a waste of space to have this much margin. I guess the intention is that there should be text next to the icons.

I've fixed it so that when you resize the dialog, the middle section is receiving the additional size too, as it is likely the reason the dialog is resized. The right-most section will rarely need resizing after the initial size is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Something isn't working user interface Component: General user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants